feat(onboarding): Add logs to react router onboarding #97438
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
![seer-by-sentry[bot]](https://avatars.githubusercontent.com/in/801464?s=60&v=4){kind=small}
Comment on lines
214
to
216
| Sentry.logger.info("User triggered test error", { | ||
| 'action': SentryLogAttribute.string('test_loader_error'), | ||
| });` |
There was a problem hiding this comment.
Potential bug: The React Router onboarding doc uses an undefined `SentryLogAttribute`, which will cause a `ReferenceError` and crash the user's application during verification.
- Description: The code in the React Router getting started documentation at
Sentry.logger.infousesSentryLogAttribute.string('test_loader_error'). TheSentryLogAttributeobject is not defined in the Sentry JavaScript SDK or imported anywhere in the codebase. When a user copies and executes this code snippet during the onboarding verification step, their application will throw aReferenceError: SentryLogAttribute is not defined. This crash prevents users from successfully verifying their Sentry setup for React Router when logs are enabled, breaking a key part of the onboarding flow. - Suggested fix: Remove the call to the undefined
SentryLogAttribute.string()wrapper. The value for theactionkey should be a plain string, like'test_loader_error', consistent with other JavaScript onboarding documentation and the Sentry SDK's API.
severity: 0.8, confidence: 1.0
Did we get this right? 👍 / 👎 to inform future reviews.
AbhiPrasad
commented
Aug 8, 2025
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
andrewshie-sentry
pushed a commit
that referenced
this pull request
Aug 12, 2025
resolves https://linear.app/getsentry/issue/LOGS-249/add-logs-to-react-router-onboarding resolves https://linear.app/getsentry/issue/LOGS-290/add-verify-steps-to-react-router-js-onboarding also adds tests and cleans up snippet code adding. Should match https://docs.sentry.io/platforms/javascript/guides/react-router/ better now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves https://linear.app/getsentry/issue/LOGS-249/add-logs-to-react-router-onboarding
resolves https://linear.app/getsentry/issue/LOGS-290/add-verify-steps-to-react-router-js-onboarding
also adds tests and cleans up snippet code adding. Should match https://docs.sentry.io/platforms/javascript/guides/react-router/ better now.